[Backport v4.0-branch] soc: sam0: samd5x: xosc32 configurable startup time #83103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Kconfig option to configure the startup time of the external 32KHz crystal oscillator. Signed-off-by: Thomas Schranz <[email protected]> (cherry picked from commit cd20154)
zephyrbot
added
Backport
zephyrbot
requested review from
attie-argentum,
mnkp,
pdgendt and
stephanosio
stephanosio
approved these changes
Dec 17, 2024
pdgendt
approved these changes
Dec 17, 2024
nandojve
approved these changes
Dec 18, 2024
|
#83147 is an enhancement. We usually only backport bug fixes. What's the rationale for backporting this? |
The xosc32 is used as source of PLL to provide cpu main clock and users should be able to configure the right start-up time to avoid boot issues. I can create an special issue if required. see zephyr/soc/atmel/sam0/common/soc_samd5x.c Lines 61 to 62 in 27615a7 |
|
I'm on the same page with @henrikbrixandersen here, this has a look and smell of an enhancement. The provided issue didn't give me any details why this is a bug. |
henrikbrixandersen
approved these changes
Jan 15, 2025
dkalowsk
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cd20154 from #82951.
Fixes #83147